From 3313664b70733e4d6afcc9b5752b3d7cd1d2c729 Mon Sep 17 00:00:00 2001 From: Gabor Kiss-Vamosi Date: Thu, 22 Aug 2024 02:16:47 +0200 Subject: [PATCH] chore: move the astyle repo to the lvgl organization (#6614) --- .github/pull_request_template.md | 4 +--- .github/workflows/check_style.yml | 2 +- scripts/install_astyle.sh | 16 ++++++++++++++++ 3 files changed, 18 insertions(+), 4 deletions(-) create mode 100755 scripts/install_astyle.sh diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 92fc8905e..51ee0c8bf 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,3 @@ -### Description of the feature or fix - A clear and concise description of what the bug or new feature is. ### Notes @@ -7,7 +5,7 @@ A clear and concise description of what the bug or new feature is. - Add [Examples](https://github.com/lvgl/lvgl/tree/master/examples) if relevant. - Add [Tests](https://github.com/lvgl/lvgl/blob/master/tests/README.md) if applicable. - If you added new options to `lv_conf_template.h` run [lv_conf_internal_gen.py](https://github.com/lvgl/lvgl/blob/master/scripts/lv_conf_internal_gen.py) and update [Kconfig](https://github.com/lvgl/lvgl/blob/master/Kconfig). -- Run `scripts/code-format.py` ([astyle](http://astyle.sourceforge.net/install.html) version [v3.4.12](https://github.com/szepeviktor/astyle/releases/tag/v3.4.12) needs to be installed) and follow the [Code Conventions](https://docs.lvgl.io/master/CODING_STYLE.html). +- Run `scripts/code-format.py` (`astyle v3.4.12` needs to installed by running `cd scripts; ./install_astyle.sh`) and follow the [Code Conventions](https://docs.lvgl.io/master/CODING_STYLE.html). - Mark the Pull request as [Draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request) while you are working on the first version, and mark is as _Ready_ when it's ready for review. - When changes were requested, [re-request review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review) to notify the maintainers. - Help us to review this Pull Request! Anyone can [approve or request changes](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews). diff --git a/.github/workflows/check_style.yml b/.github/workflows/check_style.yml index a45dbbce1..6c3a42820 100644 --- a/.github/workflows/check_style.yml +++ b/.github/workflows/check_style.yml @@ -16,7 +16,7 @@ jobs: - name: Checkout astyle uses: actions/checkout@v4 with: - repository: szepeviktor/astyle + repository: lvgl/astyle path: astyle ref: v3.4.12 - name: Install astyle diff --git a/scripts/install_astyle.sh b/scripts/install_astyle.sh new file mode 100755 index 000000000..0050d9141 --- /dev/null +++ b/scripts/install_astyle.sh @@ -0,0 +1,16 @@ +#!/bin/sh + +# Check if the script is being run as root +if [ "$(id -u)" -ne 0 ]; then + echo "This script must be run as root or with sudo" >&2 + exit 1 +fi + +rm -rf astyle +git clone https://github.com/lvgl/astyle.git +cd astyle/build/gcc +git checkout v3.4.12 +make -j +make install +cd ../../.. +rm -rf astyle