FPGA/corundum
1
0
Fork 0
mirror of https://github.com/corundum/corundum.git synced 2025-01-16 08:12:53 +08:00
Code Issues Projects Releases Wiki Activity

mqnic_i2c: Fix device_attach() error handling

Browse Source 
If the device_attach() function fails, make sure "client" is free'd and
that the create_i2c_client() function returns NULL to signal an error to
callers.

Signed-off-by: Pekka Enberg <penberg@iki.fi>
This commit is contained in:
Pekka Enberg 2020-12-29 11:13:27 +02:00 committed by Alex Forencich
parent 2a24722d7f
commit 57809dad90
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/mqnic/mqnic_i2c.c
View File

@ -96,6 +96,7 @@ static struct i2c_client *create_i2c_client(struct i2c_adapter *adapter, const c
{
struct i2c_client *client;
struct i2c_board_info board_info;
int err;
if (!adapter)
return NULL;
@ -115,9 +116,15 @@ static struct i2c_client *create_i2c_client(struct i2c_adapter *adapter, const c
return NULL;
// force driver load (mainly for muxes so we can talk to downstream devices)
device_attach(&client->dev);
err = device_attach(&client->dev);
if (err < 0)
goto err_free_client;
return client;
err_free_client:
i2c_unregister_device(client);
return NULL;
}
static struct i2c_adapter *get_i2c_mux_channel(struct i2c_client *mux, u32 chan_id)