FPGA/corundum
1
0
Fork 0
mirror of https://github.com/corundum/corundum.git synced 2025-01-30 08:32:52 +08:00
Code Issues Projects Releases Wiki Activity

modules/mqnic: fix SFP EEPROM readout to support optical module diagnosis

Browse Source 
* fix offset check for allowing an offset of exactly 256 Bytes
* fix allowing the I2C address of 0x51 to access the optical SFP modules
  diagnosis information, see SFF8472 rev 12.4 p. 8
This commit is contained in:
Ulrich Langenbach 2022-08-11 09:54:56 +02:00 committed by Alex Forencich
parent 448fa8eb4c
commit 6bd8ae031f
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/mqnic/mqnic_ethtool.c
View File

@ -339,21 +339,22 @@ static int mqnic_query_module_eeprom_by_page(struct net_device *ndev,
case SFF_MODULE_ID_SFP: case SFF_MODULE_ID_SFP:
if (page > 0 || bank > 0) if (page > 0 || bank > 0)
return -EINVAL; return -EINVAL;
if (i2c_addr != 0x50 && i2c_addr != 0x51)
return -EINVAL;
break; break;
case SFF_MODULE_ID_QSFP: case SFF_MODULE_ID_QSFP:
case SFF_MODULE_ID_QSFP_PLUS: case SFF_MODULE_ID_QSFP_PLUS:
case SFF_MODULE_ID_QSFP28: case SFF_MODULE_ID_QSFP28:
if (page > 3 || bank > 0) if (page > 3 || bank > 0)
return -EINVAL; return -EINVAL;
if (i2c_addr != 0x50)
return -EINVAL;
break; break;
default: default:
netdev_err(ndev, "%s: Unknown module ID (0x%x)", __func__, module_id); netdev_err(ndev, "%s: Unknown module ID (0x%x)", __func__, module_id);
return -EINVAL; return -EINVAL;
} }
if (i2c_addr != 0x50)
return -EINVAL;
// set page // set page
switch (module_id) { switch (module_id) {
case SFF_MODULE_ID_SFP: case SFF_MODULE_ID_SFP:
@ -396,7 +397,7 @@ static int mqnic_query_module_eeprom(struct net_device *ndev,
case SFF_MODULE_ID_SFP: case SFF_MODULE_ID_SFP:
i2c_addr = 0x50; i2c_addr = 0x50;
page = 0; page = 0;
if (offset > 256) { if (offset >= 256) {
offset -= 256; offset -= 256;
i2c_addr = 0x51; i2c_addr = 0x51;
} }