GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-09 00:56:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

evhttp: fix leak from keep-alive disconnect or read/write timeout

Browse Source 
When a keep-alive HTTP/1.1 connection disconnects, or when there's
a read or write timeout (default after 60 seconds), evhttp failed to
free the connection context memory.
This commit is contained in:
Pierce Lopez 2015-01-28 13:37:16 -05:00
parent 2216a9bdba
commit 46a1375b59
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
http.c
View File

@ -695,9 +695,13 @@ void
evhttp_write(int fd, short what, void *arg)
{
struct evhttp_connection *evcon = arg;
struct evhttp_request *req = TAILQ_FIRST(&evcon->requests);
int n;
if (what == EV_TIMEOUT) {
if (req != NULL) {
req->userdone = 1;
}
evhttp_connection_fail(evcon, EVCON_HTTP_TIMEOUT);
return;
}
@ -935,6 +939,7 @@ evhttp_read(int fd, short what, void *arg)
int n, len;
if (what == EV_TIMEOUT) {
req->userdone = 1;
evhttp_connection_fail(evcon, EVCON_HTTP_TIMEOUT);
return;
}
@ -2239,6 +2244,7 @@ evhttp_handle_request(struct evhttp_request *req, void *arg)
if (req->uri == NULL) {
event_debug(("%s: bad request", __func__));
if (req->evcon->state == EVCON_DISCONNECTED) {
req->userdone = 1;
evhttp_connection_fail(req->evcon, EVCON_HTTP_EOF);
} else {
event_debug(("%s: sending error", __func__));