GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-31 09:12:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix tinytest invocation from windows shell

Browse Source 
Original post:

  This post is in response to a posting last December on a Windows
  regression fork failure ([Libevent-users] Re: Libevent 2.0.10-stable
  is released by Dongsheng Song).  I noticed the question was not
  answered and I recently experienced the same error myself when
  trying to run the Windows regression tests myself.

  I checked the return status from the CreateProcess call and found it
  was "file not found".  This led me to look at the command-line I was
  using which was .\regress in a Visual Studio 2008 command prompt
  window.  Windows could not find the file because it did not have the
  .exe extension on the end.  The code that builds the command should
  be modified to ensure the extension is present.
This commit is contained in:
Ed Day 2011-06-11 00:49:24 -04:00 committed by Nick Mathewson
parent 446cc7a0a1
commit 57def3460a
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/tinytest.c
View File

@ -67,7 +67,7 @@ const char *cur_test_name = NULL;
#ifdef WIN32
/** Pointer to argv[0] for win32. */
static const char *commandname = NULL;
static char *commandname = NULL;
#endif
static void usage(struct testgroup_t *groups, int list_groups)
@ -291,7 +291,19 @@ tinytest_main(int c, const char **v, struct testgroup_t *groups)
int i, j, n=0;
#ifdef WIN32
commandname = v[0];
const char* sp = strrchr (v[0], '.');
if (0 != sp) {
if (0 != stricmp (sp, ".exe")) { /* not exe extension */
sp = 0;
}
}
if (0 == sp) {
commandname = (char*) malloc (strlen(v[0]) + 5);
strcpy (commandname, v[0]);
strcat (commandname, ".exe");
}
else
commandname = strdup (v[0]);
#endif
for (i=1; i<c; ++i) {
if (v[i][0] == '-') {
@ -314,6 +326,7 @@ tinytest_main(int c, const char **v, struct testgroup_t *groups)
usage(groups, 1);
} else {
printf("Unknown option %s. Try --help\n",v[i]);
free (commandname);
return -1;
}
} else {
@ -327,6 +340,7 @@ tinytest_main(int c, const char **v, struct testgroup_t *groups)
}
if (!_tinytest_set_flag(groups, test, flag)) {
printf("No such test as %s!\n", v[i]);
free (commandname);
return -1;
}
}
@ -354,6 +368,8 @@ tinytest_main(int c, const char **v, struct testgroup_t *groups)
else if (opt_verbosity >= 1)
printf("%d tests ok. (%d skipped)\n", n_ok, n_skipped);
free (commandname);
return (n_bad == 0) ? 0 : 1;
}