GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-31 09:12:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use EV_PERSIST on notify event for efficiency and simplicity.

Browse Source 
svn:r1039
This commit is contained in:
Nick Mathewson 2009-01-22 17:48:55 +00:00
parent 20c20466fb
commit 5e6f6dcd1b
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
event.c
View File

@ -1561,20 +1561,15 @@ evthread_set_locking_callback(struct event_base *base,
static void static void
evthread_notify_drain_eventfd(int fd, short what, void *arg) evthread_notify_drain_eventfd(int fd, short what, void *arg)
{ {
struct event_base *base = arg;
ev_uint64_t msg; ev_uint64_t msg;
read(fd, (void*) &msg, sizeof(msg)); read(fd, (void*) &msg, sizeof(msg));
/* XXX Why not make th_notify EV_PERSIST? */
event_add(&base->th_notify, NULL);
} }
#endif #endif
static void static void
evthread_notify_drain_default(evutil_socket_t fd, short what, void *arg) evthread_notify_drain_default(evutil_socket_t fd, short what, void *arg)
{ {
struct event_base *base = arg;
unsigned char buf[128]; unsigned char buf[128];
#ifdef WIN32 #ifdef WIN32
while (recv(fd, (char*)buf, sizeof(buf), 0) > 0) while (recv(fd, (char*)buf, sizeof(buf), 0) > 0)
@ -1583,9 +1578,6 @@ evthread_notify_drain_default(evutil_socket_t fd, short what, void *arg)
while (read(fd, (char*)buf, sizeof(buf)) > 0) while (read(fd, (char*)buf, sizeof(buf)) > 0)
; ;
#endif #endif
/* XXX Why not make th_notify EV_PERSIST? */
event_add(&base->th_notify, NULL);
} }
void void
@ -1655,8 +1647,8 @@ evthread_make_base_notifiable(struct event_base *base)
// evutil_make_socket_nonblocking(base->th_notify_fd[1]); // evutil_make_socket_nonblocking(base->th_notify_fd[1]);
/* prepare an event that we can use for wakeup */ /* prepare an event that we can use for wakeup */
event_assign(&base->th_notify, base, base->th_notify_fd[0], EV_READ, event_assign(&base->th_notify, base, base->th_notify_fd[0],
cb, base); EV_READ|EV_PERSIST, cb, base);
/* we need to mark this as internal event */ /* we need to mark this as internal event */
base->th_notify.ev_flags |= EVLIST_INTERNAL; base->th_notify.ev_flags |= EVLIST_INTERNAL;