GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-31 09:12:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix unlikely (for libevent) UB in HT_GROW()

Browse Source 
The reason it is not possible for libevent is that:
a) it is unlikely to have 1610612741 elements
b) growing is done incrementally (i.e. only internally by HT_INSERT) and
   in this case the UB is not possible

Fixes: https://github.com/libevent/libevent/issues/1312
This commit is contained in:
Azat Khuzhin 2024-11-02 21:41:32 +01:00 committed by Azat Khuzhin
parent 98b7ca30b2
commit 78eb305975
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ht-internal.h
View File

@ -309,7 +309,7 @@ ht_string_hash_(const char *s)
805306457, 1610612741 \ 805306457, 1610612741 \
}; \ }; \
static unsigned name##_N_PRIMES = \ static unsigned name##_N_PRIMES = \
(unsigned)(sizeof(name##_PRIMES)/sizeof(name##_PRIMES[0])); \ (unsigned)(sizeof(name##_PRIMES)/sizeof(name##_PRIMES[0])) - 1; \
/* Expand the internal table of 'head' until it is large enough to \ /* Expand the internal table of 'head' until it is large enough to \
* hold 'size' elements. Return 0 on success, -1 on allocation \ * hold 'size' elements. Return 0 on success, -1 on allocation \
* failure. */ \ * failure. */ \
@ -319,7 +319,7 @@ ht_string_hash_(const char *s)
unsigned new_len, new_load_limit; \ unsigned new_len, new_load_limit; \
int prime_idx; \ int prime_idx; \
struct type **new_table; \ struct type **new_table; \
if (head->hth_prime_idx == (int)name##_N_PRIMES - 1) \ if (head->hth_prime_idx == (int)name##_N_PRIMES) \
return 0; \ return 0; \
if (head->hth_load_limit > size) \ if (head->hth_load_limit > size) \
return 0; \ return 0; \