GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-09 00:56:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that event had been removed in event_process_active_single_queue()

Browse Source 
It should not be possible, since only EVLIST_ACTIVE should be triggered
from event_process_active_single_queue, but adding assert will not hurt.
This commit is contained in:
Cœur 2024-05-06 23:31:27 +08:00 committed by Azat Khuzhin
parent 8976100a44
commit 7afbdcf25e
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
event.c
View File

@ -1677,7 +1677,7 @@ event_process_active_single_queue(struct event_base *base,
EVUTIL_ASSERT(activeq != NULL);
for (evcb = TAILQ_FIRST(activeq); evcb; evcb = TAILQ_FIRST(activeq)) {
struct event *ev=NULL;
struct event *ev = NULL;
if (evcb->evcb_flags & EVLIST_INIT) {
ev = event_callback_to_event(evcb);
@ -1698,6 +1698,9 @@ event_process_active_single_queue(struct event_base *base,
"closure %d, call %p",
(void *)evcb, evcb->evcb_closure, (void *)evcb->evcb_cb_union.evcb_callback));
}
// We don't want an infinite loop or use of memory after it is freed.
// Hence, for next loop iteration, it is expected that `event_queue_remove_active` or `event_del_nolock_` have removed current event from the queue at this point.
EVUTIL_ASSERT(evcb != TAILQ_FIRST(activeq));
if (!(evcb->evcb_flags & EVLIST_INTERNAL))
++count;