GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-09 00:56:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove spurious checks in evrpc.c error cases (coverity)

Browse Source 
Coverity hates the case where you have a redundant NULL check after
using something.
This commit is contained in:
Nick Mathewson 2014-01-08 12:04:06 -05:00
parent 544cf8888a
commit 991b362001
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
evrpc.c
View File

@ -329,8 +329,7 @@ evrpc_request_cb(struct evhttp_request *req, void *arg)
return;
error:
if (rpc_state != NULL)
evrpc_reqstate_free_(rpc_state);
evrpc_reqstate_free_(rpc_state);
evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL);
return;
}
@ -372,8 +371,7 @@ evrpc_request_cb_closure(void *arg, enum EVRPC_HOOK_RESULT hook_res)
return;
error:
if (rpc_state != NULL)
evrpc_reqstate_free_(rpc_state);
evrpc_reqstate_free_(rpc_state);
evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL);
return;
}
@ -454,8 +452,7 @@ evrpc_request_done(struct evrpc_req_generic *rpc_state)
return;
error:
if (rpc_state != NULL)
evrpc_reqstate_free_(rpc_state);
evrpc_reqstate_free_(rpc_state);
evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL);
return;
}