From 991b362001b0d31cc175d78c24a6de2d7137c56a Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Wed, 8 Jan 2014 12:04:06 -0500 Subject: [PATCH] Remove spurious checks in evrpc.c error cases (coverity) Coverity hates the case where you have a redundant NULL check after using something. --- evrpc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/evrpc.c b/evrpc.c index 8d8ecc5a..83230d4c 100644 --- a/evrpc.c +++ b/evrpc.c @@ -329,8 +329,7 @@ evrpc_request_cb(struct evhttp_request *req, void *arg) return; error: - if (rpc_state != NULL) - evrpc_reqstate_free_(rpc_state); + evrpc_reqstate_free_(rpc_state); evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL); return; } @@ -372,8 +371,7 @@ evrpc_request_cb_closure(void *arg, enum EVRPC_HOOK_RESULT hook_res) return; error: - if (rpc_state != NULL) - evrpc_reqstate_free_(rpc_state); + evrpc_reqstate_free_(rpc_state); evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL); return; } @@ -454,8 +452,7 @@ evrpc_request_done(struct evrpc_req_generic *rpc_state) return; error: - if (rpc_state != NULL) - evrpc_reqstate_free_(rpc_state); + evrpc_reqstate_free_(rpc_state); evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL); return; }