GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-31 09:12:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

configure: avoid false positive in DragonFlyBSD

Browse Source 
by default, the max buffer size is 16K and histeresis is at 50%, so
a bigger read is needed to unlock writes than you would expect from
other BSD (512 bytes)

this doesn't introduce any regression on FreeBSD 11.1, OpenBSD 6.1, NetBSD 7.1,
macOS 10.12.6 and of course DragonFlyBSD 4.8.1, and most of them show
a max pipe size of 64K, so the read call should drain them all regardless
of how conservative they are on the free pipe space they will require
(usually 512 bytes) before kevent reports the fd as ready for write.

I couldn't find a reference to which bug this code was trying to look for
and it seems to be there from the beginning of git history so it might be
no longer relevant.

Issue: #548
(cherry picked from commit 1dfec8a97094a26317eac9b3d8a1c16eb1a7dbea)
This commit is contained in:
Carlo Marcelo Arenas Belón 2017-08-19 16:01:46 -07:00 committed by Azat Khuzhin
parent 1811a040ef
commit 9c720b7073
No known key found for this signature in database
GPG Key ID: B86086848EF8686D
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmake/CheckWorkingKqueue.cmake
View File

@ -17,7 +17,7 @@ main(int argc, char **argv)
int fd[2];
struct kevent ev;
struct timespec ts;
char buf[8000];
char buf[80000];
if (pipe(fd) == -1)
exit(1);
@ -27,7 +27,7 @@ main(int argc, char **argv)
while ((n = write(fd[1], buf, sizeof(buf))) == sizeof(buf))
;
if ((kq = kqueue()) == -1)
if ((kq = kqueue()) == -1)
exit(1);
memset(&ev, 0, sizeof(ev));
@ -49,4 +49,4 @@ main(int argc, char **argv)
exit(0);
}
" EVENT__HAVE_WORKING_KQUEUE)
" EVENT__HAVE_WORKING_KQUEUE)

8
configure.ac
View File

@ -517,6 +517,12 @@ if test "x$ac_cv_header_sys_event_h" = "xyes"; then
if test "x$havekqueue" = "xyes" ; then
AC_MSG_CHECKING(for working kqueue)
AC_TRY_RUN(
#ifdef HAVE_STDLIB_H
#include <stdlib.h>
#endif
#ifdef HAVE_STRING_H
#include <string.h>
#endif
#include <sys/types.h>
#include <sys/time.h>
#include <sys/event.h>
@ -532,7 +538,7 @@ main(int argc, char **argv)
int fd[[2]];
struct kevent ev;
struct timespec ts;
char buf[[8000]];
char buf[[80000]];
if (pipe(fd) == -1)
exit(1);