GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-31 09:12:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid close of uninitialized socket in evbuffer unit test

Browse Source 
Attempts to fix a crash bug found by Brodie Thiesfield.
This commit is contained in:
Nick Mathewson 2010-05-17 11:58:07 -04:00
parent caca2f451c
commit bda21e7ff9
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/regress_buffer.c
View File

@ -595,7 +595,7 @@ test_evbuffer_add_file(void *ptr)
const char *data = "this is what we add as file system data."; const char *data = "this is what we add as file system data.";
size_t datalen; size_t datalen;
const char *compare; const char *compare;
evutil_socket_t fd, pair[2]; evutil_socket_t fd = -1, pair[2] = {-1, -1};
int r=0, n_written=0; int r=0, n_written=0;
/* Add a test for a big file. XXXX */ /* Add a test for a big file. XXXX */
@ -647,8 +647,10 @@ test_evbuffer_add_file(void *ptr)
evbuffer_validate(src); evbuffer_validate(src);
end: end:
evutil_closesocket(pair[0]); if (pair[0] >= 0)
evutil_closesocket(pair[1]); evutil_closesocket(pair[0]);
if (pair[1] >= 0)
evutil_closesocket(pair[1]);
evbuffer_free(src); evbuffer_free(src);
} }