From c8501afc0cde1a1d8f95daf293ea9fc7feff6e59 Mon Sep 17 00:00:00 2001 From: Azat Khuzhin Date: Sat, 9 Jul 2022 17:17:38 +0300 Subject: [PATCH] http: suppress "flags may be used uninitialized in this function" error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some GCC reports [1]: /home/runner/work/libevent/libevent/http.c: In function ‘evhttp_make_header’: /home/runner/work/libevent/libevent/http.c:503:14: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ev_uint16_t flags; ^~~~~ /home/runner/work/libevent/libevent/http.c: In function ‘evhttp_get_body’: /home/runner/work/libevent/libevent/http.c:2354:14: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ev_uint16_t flags; ^~~~~ [1]: https://github.com/libevent/libevent/runs/7263518338?check_suite_focus=true#logs --- http.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/http.c b/http.c index 9cebbb7c..d578735d 100644 --- a/http.c +++ b/http.c @@ -500,7 +500,8 @@ evhttp_make_header_request(struct evhttp_connection *evcon, struct evhttp_request *req) { const char *method; - ev_uint16_t flags; + /* NOTE: some version of GCC reports a warning that flags may be uninitialized, hence assignment */ + ev_uint16_t flags = 0; evhttp_remove_header(req->output_headers, "Proxy-Connection"); @@ -2351,7 +2352,8 @@ evhttp_get_body_length(struct evhttp_request *req) static int evhttp_method_may_have_body_(struct evhttp_connection *evcon, enum evhttp_cmd_type type) { - ev_uint16_t flags; + /* NOTE: some version of GCC reports a warning that flags may be uninitialized, hence assignment */ + ev_uint16_t flags = 0; evhttp_method_(evcon, type, &flags); return (flags & EVHTTP_METHOD_HAS_BODY) ? 1 : 0; }