GitHub/libevent
1
0
Fork 0
mirror of https://github.com/libevent/libevent.git synced 2025-01-31 09:12:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Complain if the caller tries to change threading cbs after setting them

Browse Source 
We never supported this; it was always fraught with errors; and I
don't believe there is a good reason to _want_ it to work.
This commit is contained in:
Nick Mathewson 2011-04-22 12:40:07 -04:00
parent b683cae3cb
commit cb6ecee7f6
1 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
evthread.c
View File

@ -76,9 +76,22 @@ evthread_set_lock_callbacks(const struct evthread_lock_callbacks *cbs)
? &_original_lock_fns : &_evthread_lock_fns; ? &_original_lock_fns : &_evthread_lock_fns;
if (!cbs) { if (!cbs) {
if (target->alloc)
event_warnx("Trying to disable lock functions after "
"they have been set up will probaby not work.");
memset(target, 0, sizeof(_evthread_lock_fns)); memset(target, 0, sizeof(_evthread_lock_fns));
return 0; return 0;
} }
if (target->alloc) {
/* Uh oh; we already had locking callbacks set up.*/
if (!memcmp(target, cbs, sizeof(_evthread_lock_fns))) {
/* no change -- allow this. */
return 0;
}
event_warnx("Can't change lock callbacks once they have been "
"initialized.");
return -1;
}
if (cbs->alloc && cbs->free && cbs->lock && cbs->unlock) { if (cbs->alloc && cbs->free && cbs->lock && cbs->unlock) {
memcpy(target, cbs, sizeof(_evthread_lock_fns)); memcpy(target, cbs, sizeof(_evthread_lock_fns));
return event_global_setup_locks_(1); return event_global_setup_locks_(1);
@ -95,8 +108,24 @@ evthread_set_condition_callbacks(const struct evthread_condition_callbacks *cbs)
? &_original_cond_fns : &_evthread_cond_fns; ? &_original_cond_fns : &_evthread_cond_fns;
if (!cbs) { if (!cbs) {
if (target->alloc_condition)
event_warnx("Trying to disable condition functions "
"after they have been set up will probaby not "
"work.");
memset(target, 0, sizeof(_evthread_cond_fns)); memset(target, 0, sizeof(_evthread_cond_fns));
} else if (cbs->alloc_condition && cbs->free_condition && return 0;
}
if (target->alloc_condition) {
/* Uh oh; we already had condition callbacks set up.*/
if (!memcmp(target, cbs, sizeof(_evthread_cond_fns))) {
/* no change -- allow this. */
return 0;
}
event_warnx("Can't change condition callbacks once they "
"have been initialized.");
return -1;
}
if (cbs->alloc_condition && cbs->free_condition &&
cbs->signal_condition && cbs->wait_condition) { cbs->signal_condition && cbs->wait_condition) {
memcpy(target, cbs, sizeof(_evthread_cond_fns)); memcpy(target, cbs, sizeof(_evthread_cond_fns));
} }