Reduce windows header includes in our own headers.

It turns out that absolutely everything that was including
windows.h was doing so needlessly; our headers don't need it,
so we should just include winsock2.h (since that's where
struct timeval is defined).

Pre-2.0 code will use the old headers, which include windows.h
for them, so we aren't breaking source compatibility with 1.4.

This solves the bug where we were leaving WIN32_LEAN_AND_MEAN
defined, in roughly the same way that buying an automobile
solves the question of what to give your coachman for boxing
day.

evdns.c

@@ -101,7 +101,9 @@
 #ifdef WIN32
 #include <winsock2.h>
 #include <ws2tcpip.h>
+#ifndef _WIN32_IE
 #define _WIN32_IE 0x400
+#endif
 #include <shlobj.h>
 #endif
 

include/event2/bufferevent.h

@@ -65,13 +65,6 @@ extern "C" {
 /* For int types. */
 #include <event2/util.h>
 
-#ifdef WIN32
-#define WIN32_LEAN_AND_MEAN
-#include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
-#endif
-
-
 /* Just for error reporting - use other constants otherwise */
 #define BEV_EVENT_READING	0x01	/**< error encountered while reading */
 #define BEV_EVENT_WRITING	0x02	/**< error encountered while writing */

include/event2/bufferevent_struct.h

@@ -51,12 +51,6 @@ extern "C" {
 /* For struct event */
 #include <event2/event_struct.h>
 
-#ifdef WIN32
-#define WIN32_LEAN_AND_MEAN
-#include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
-#endif
-
 struct event_watermark {
 	size_t low;
 	size_t high;

include/event2/event.h

@@ -50,12 +50,6 @@ extern "C" {
 /* For int types. */
 #include <event2/util.h>
 
-#ifdef WIN32
-#define WIN32_LEAN_AND_MEAN
-#include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
-#endif
-
 struct event_base;
 struct event;
 struct event_config;

include/event2/event_compat.h

@@ -49,12 +49,6 @@ extern "C" {
 /* For int types. */
 #include <event2/util.h>
 
-#ifdef WIN32
-#define WIN32_LEAN_AND_MEAN
-#include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
-#endif
-
 /**
   Initialize the event API.
 

include/event2/event_struct.h

@@ -49,13 +49,6 @@ extern "C" {
 /* For int types. */
 #include <event2/util.h>
 
-#ifdef WIN32
-#include <winsock2.h>
-#define WIN32_LEAN_AND_MEAN
-#include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
-#endif
-
 #define EVLIST_TIMEOUT	0x01
 #define EVLIST_INSERTED	0x02
 #define EVLIST_SIGNAL	0x04

include/event2/http.h

@@ -34,13 +34,6 @@
 extern "C" {
 #endif
 
-#ifdef WIN32
-#define WIN32_LEAN_AND_MEAN
-#include <winsock2.h>
-#include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
-#endif
-
 /* In case we haven't included the right headers yet. */
 struct evbuffer;
 struct event_base;

include/event2/http_compat.h

@@ -49,12 +49,6 @@ extern "C" {
 /* For int types. */
 #include <event2/util.h>
 
-#ifdef WIN32
-#define WIN32_LEAN_AND_MEAN
-#include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
-#endif
-
 /**
  * Start an HTTP server on the specified address and port
  *

include/event2/tag.h

@@ -48,12 +48,6 @@ extern "C" {
 /* For int types. */
 #include <event2/util.h>
 
-#ifdef WIN32
-#define WIN32_LEAN_AND_MEAN
-#include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
-#endif
-
 struct evbuffer;
 
 /*

include/event2/util.h

@@ -63,6 +63,10 @@ extern "C" {
 #include <netdb.h>
 #endif
 
+#ifdef WIN32
+#include <winsock2.h>
+#endif
+
 /* Integer type definitions for types that are supposed to be defined in the
  * C99-specified stdint.h.  Shamefully, some platforms do not include
  * stdint.h, so we need to replace it.  (If you are on a platform like this,