2279 Commits

Author SHA1 Message Date
Nick Mathewson
0a822a640e Avoid double-close on getsockname error in evutil_ersatz_socketpair
Found by coverity; CID 739726
2012-12-20 11:48:05 -05:00
Nick Mathewson
69db2610be Avoid leaking fds on evconnlistener with no callback set
There's no way to retrieve an fd from an evconnlistener whose
callback has been cleared, so we had better close any such fd.

Found by coverity; CID 739725.
2012-12-20 11:47:09 -05:00
Nick Mathewson
7e45739e26 Fix compilation with WIN32_HAVE_CONDITION_VARIABLES enabled
Reported by Xiuqiang Jiang
2012-12-04 12:01:58 -05:00
Nick Mathewson
f7d92c6392 Increment version to 2.0.21-stable-dev 2012-11-19 10:56:16 -05:00
Nick Mathewson
6417777716 Increment libtool version for 2.0.21 too release-2.0.21-stable 2012-11-18 01:39:10 -05:00
Nick Mathewson
0ee10fdfee Increment version to 2.0.21-stable 2012-11-18 01:38:07 -05:00
Nick Mathewson
1c5517c97c Changelog for 2.0.21-stable 2012-11-18 01:36:33 -05:00
Nick Mathewson
f38e078868 Make ssl version check in unit tests work 2012-11-18 01:36:03 -05:00
Nick Mathewson
e3cccf380c Avoid crash when event_pending() called with no event_base set on event
Instead, give a warning and return 0.

Reported by Antony Dovgal on github as
   https://github.com/libevent/libevent/issues/19
2012-11-16 11:56:56 -05:00
Patrick Pelletier
ac356502d3 remove stray 'x' so print_err will compile when uncommented 2012-11-16 10:44:24 -05:00
Nick Mathewson
f3009e48c7 Make rpcgen_wrapper.sh work on systems without a "python2" binary 2012-11-16 10:28:19 -05:00
Nick Mathewson
ac009f9245 Warn when openssl version in unit test mismatches compiled version. 2012-11-15 11:43:45 -05:00
Nick Mathewson
c2f30863e2 Fix renegotiation test to work around openssl 1.0.1 bug
There's a bug in openssl 1.0.1 where TLS1.1 and TLS1.2 can't
renegotiate with themselves.  When testing renegotiation with OpenSSL
>=1.0.1 and <1.0.1d, disable those protocols.
2012-11-15 11:43:45 -05:00
Nick Mathewson
62bd2c44f1 Fix compilation on mingw64 with -DUSE_DEBUG 2012-11-02 11:44:29 -04:00
Nick Mathewson
94866c2763 Compile without warnings on mingw64
This is mostly a matter of catching cases where we were still
assuming that evutil_socket_t could be used as an int.
2012-11-01 17:56:06 -04:00
Nick Mathewson
2479d96405 Merge remote-tracking branch 'rosslagerwall/python2-2.0' into patches-2.0 2012-10-26 19:36:44 -04:00
Juan Pablo Fernandez
cb853ea36c Close IOCP listener socket on free when LEV_OPT_CLOSE_ON_FREE is set 2012-10-26 19:33:31 -04:00
Nick Mathewson
1ff2c249bd Merge remote-tracking branch 'public/20_bev_timeout_semantics' into patches-2.0 2012-10-24 22:48:59 -04:00
Ross Lagerwall
0eb01099da Use python2 rather than python
python may refer to either python2 or python3 so rather by explicit by
using python2.
See PEP 394 - http://www.python.org/dev/peps/pep-0394/ for more
details.
2012-10-23 13:30:58 +01:00
Joachim Bauch
1acf2ebcff No need to reserve space if reading is suspended.
Conflicts:
	bufferevent_openssl.c
2012-09-22 18:09:21 -04:00
Joachim Bauch
f719b8a918 Stop looping in "consider_reading" if reading is suspended. 2012-09-22 18:06:57 -04:00
George Danchev
f2bff75ed8 FIx another memleak on OOM in evdns 2012-09-12 20:12:03 -04:00
George Danchev
73e85dd08f Avoid a memory-leak on OOM in evdns. 2012-09-12 20:11:12 -04:00
Nick Mathewson
576b29f21b Don't discard SSL read event when timeout and read come close together 2012-09-07 15:53:02 -04:00
Nick Mathewson
484e93c1d0 Increment version to 2.0.20-stable-dev 2012-08-24 11:40:46 -04:00
Nick Mathewson
41d77a7c1e Add a date to the changelog release-2.0.20-stable 2012-08-23 14:39:30 -04:00
Nick Mathewson
46604b341c Increment version to 2.0.20-stable 2012-08-23 14:38:54 -04:00
Nick Mathewson
fc43cbdcda Initial changelog and credits for 2.0.20 2012-08-23 14:33:52 -04:00
Nick Mathewson
606ac43b91 Correctly invoke callbacks when a SSL bufferevent reads some and then blocks.
Based on a patch by Andrew Hochhaus, who correctly diagnosed this bug.
2012-08-22 12:30:42 -04:00
Nick Mathewson
ca80ea61b5 Add explicit AC_PROG_SED to configure.in so all autoconfs will expose $(SED) 2012-08-02 11:56:17 -04:00
Nick Mathewson
c0720c1b0f Fix an unused variable warning on *BSD. 2012-08-02 11:38:32 -04:00
Greg Hazel
dc3207767d Avoid segfault on weird timeout during name lookup.
If an evdns_getaddrinfo timeout happens while pending_cb is set, and
a callback is about to run, but we get a call to
evdns_getaddrinfo_gotresolve before it finishes.

Github issue #60. Thanks to Greg Hazel for patch and patience.
2012-07-30 17:01:52 -04:00
Nick Mathewson
a0912e3206 Check more setsockopt return values when binding sockets. Found by coverity 2012-07-26 10:39:05 -04:00
Nick Mathewson
a1a0e67531 memset sockaddr_in before using it. Found by coverity. 2012-07-26 10:38:29 -04:00
Nick Mathewson
a2006c0087 Move assignment outside tt_assert in ssl unit tests. Appeases coverity. 2012-07-26 10:37:47 -04:00
Nick Mathewson
b9e7329751 Add checks to various return values in unit tests. Found by coverity 2012-07-26 10:37:13 -04:00
Nick Mathewson
6a4ec5c2b5 Avoid possible needless call to writev. Found by coverity. 2012-07-26 10:34:06 -04:00
Nick Mathewson
6355b2a4ca Remove unused variable; spotted by coverity 2012-07-26 10:16:47 -04:00
Nick Mathewson
3cde5bf57a Avoid more crashes/bad calls in unit tests; found by coverity 2012-07-26 10:04:43 -04:00
Nick Mathewson
f021c3d762 Add some missing null checks to unit tests; found by coverity 2012-07-26 09:59:47 -04:00
Nick Mathewson
270f279fb5 Fix resource leaks in the unit tests; found by coverity 2012-07-26 09:53:20 -04:00
Nick Mathewson
4f3732d75e Fix various check-after-dereference issues in unit tests: found by coverity 2012-07-26 09:35:43 -04:00
Nick Mathewson
f1ce15d936 Set umask before calling mkstemp in unit tests. Found by coverity 2012-07-25 16:18:33 -04:00
Nick Mathewson
2259777cc8 Fix possible uninitialized read in dns regression tests. Found by coverity. 2012-07-25 16:05:36 -04:00
Nick Mathewson
555334670a Remove deadcode in http regression tests. Found by coverity. 2012-07-25 15:59:50 -04:00
Nick Mathewson
11c8b31754 Fix a memory leak on error in evhttp_uriencode
If we ran out of memory in evhttp_uriencode when allocating the
output buffer, we would neglect to call evbuffer_free() on our
temporary buffer.  Now we always free the temporary buffer.

Fixes sourceforge issue 3539887. Thanks to Andrew Cox for reporting
this one.
2012-07-17 11:08:25 -04:00
Nick Mathewson
160e58b67d Win32: avoid crash when waiting forever on zero fds. 2012-07-16 15:34:18 -04:00
Simon Liu
be7a95c629 Make event_pending() threadsafe.
(Commit message by Nick)
2012-06-14 13:38:33 -04:00
Nick Mathewson
117e3273dc Add GCC annotations so that the vsprintf functions get checked properly 2012-06-14 13:25:10 -04:00
Nick Mathewson
60f6540341 Merge pull request #57 from rosslagerwall/memleak
Fix a couple of memory leaks (found with Valgrind).
2012-06-06 14:10:11 -07:00