2764 Commits

Author SHA1 Message Date
Nick Mathewson
9be8624b2f Merge remote-tracking branch 'origin/patches-2.0' 2012-07-30 17:08:44 -04:00
Greg Hazel
dc3207767d Avoid segfault on weird timeout during name lookup.
If an evdns_getaddrinfo timeout happens while pending_cb is set, and
a callback is about to run, but we get a call to
evdns_getaddrinfo_gotresolve before it finishes.

Github issue #60. Thanks to Greg Hazel for patch and patience.
2012-07-30 17:01:52 -04:00
Nick Mathewson
737f113a32 Extract common error-handling code in evconnlistener_new_bind 2012-07-26 10:49:06 -04:00
Nick Mathewson
6a81b1f5a4 Avoid double-free on error in evbuffer_add_file. Found by coverity. 2012-07-26 10:45:10 -04:00
Nick Mathewson
6487f63b79 Check return value when using LEV_OPT_DEFERRED_ACCEPT. Found by coverity 2012-07-26 10:44:48 -04:00
Nick Mathewson
9852107f37 Merge remote-tracking branch 'origin/patches-2.0'
Conflicts:
	buffer.c
	http.c
2012-07-26 10:43:13 -04:00
Nick Mathewson
a0912e3206 Check more setsockopt return values when binding sockets. Found by coverity 2012-07-26 10:39:05 -04:00
Nick Mathewson
a1a0e67531 memset sockaddr_in before using it. Found by coverity. 2012-07-26 10:38:29 -04:00
Nick Mathewson
a2006c0087 Move assignment outside tt_assert in ssl unit tests. Appeases coverity. 2012-07-26 10:37:47 -04:00
Nick Mathewson
b9e7329751 Add checks to various return values in unit tests. Found by coverity 2012-07-26 10:37:13 -04:00
Nick Mathewson
6a4ec5c2b5 Avoid possible needless call to writev. Found by coverity. 2012-07-26 10:34:06 -04:00
Nick Mathewson
6355b2a4ca Remove unused variable; spotted by coverity 2012-07-26 10:16:47 -04:00
Nick Mathewson
225344cfac Fix a shadowed variable in addfile_test_readcb; found by coverity 2012-07-26 10:11:17 -04:00
Nick Mathewson
92817a11aa Avoid memory leak in test_event_calloc unit test; found by coverity 2012-07-26 10:11:00 -04:00
Nick Mathewson
aa501e1a7e Add checks for functions in test-ratelim.c; found by Coverity 2012-07-26 10:10:35 -04:00
Nick Mathewson
7ef04e4b48 Merge remote-tracking branch 'origin/patches-2.0'
Conflicts:
	configure.in
	test/regress_buffer.c
	test/regress_dns.c
2012-07-26 10:09:13 -04:00
Nick Mathewson
3cde5bf57a Avoid more crashes/bad calls in unit tests; found by coverity 2012-07-26 10:04:43 -04:00
Nick Mathewson
f021c3d762 Add some missing null checks to unit tests; found by coverity 2012-07-26 09:59:47 -04:00
Nick Mathewson
270f279fb5 Fix resource leaks in the unit tests; found by coverity 2012-07-26 09:53:20 -04:00
Nick Mathewson
4f3732d75e Fix various check-after-dereference issues in unit tests: found by coverity 2012-07-26 09:35:43 -04:00
Nick Mathewson
f1ce15d936 Set umask before calling mkstemp in unit tests. Found by coverity 2012-07-25 16:18:33 -04:00
Nick Mathewson
13525c50eb Fix another possible uninitialized read in dns regression tests. Found by coverity. 2012-07-25 16:07:22 -04:00
Nick Mathewson
6fdbf3a2bc Merge remote-tracking branch 'origin/patches-2.0' 2012-07-25 16:06:51 -04:00
Nick Mathewson
2259777cc8 Fix possible uninitialized read in dns regression tests. Found by coverity. 2012-07-25 16:05:36 -04:00
Nick Mathewson
555334670a Remove deadcode in http regression tests. Found by coverity. 2012-07-25 15:59:50 -04:00
Nick Mathewson
3d83f94dfa Add process.h include to evutil.c for _getpid 2012-07-23 16:32:43 -04:00
Nick Mathewson
52a0039ba1 Fix tinytset_skip to work with new tinytest_set_flag_ signature 2012-07-20 15:36:15 -04:00
Nick Mathewson
cdb47db9e2 Fix compile error in win32 listener.c
SF issue 3546388
2012-07-20 15:35:33 -04:00
Nick Mathewson
01b65ab872 Merge remote-tracking branch 'origin/patches-2.0' 2012-07-17 11:10:44 -04:00
Nick Mathewson
11c8b31754 Fix a memory leak on error in evhttp_uriencode
If we ran out of memory in evhttp_uriencode when allocating the
output buffer, we would neglect to call evbuffer_free() on our
temporary buffer.  Now we always free the temporary buffer.

Fixes sourceforge issue 3539887. Thanks to Andrew Cox for reporting
this one.
2012-07-17 11:08:25 -04:00
Nick Mathewson
6c14d56430 Merge remote-tracking branch 'origin/patches-2.0'
Conflicts:
	event.c
	win32select.c
2012-07-16 15:44:07 -04:00
Nick Mathewson
160e58b67d Win32: avoid crash when waiting forever on zero fds. 2012-07-16 15:34:18 -04:00
Nick Mathewson
2b6fe8bb7f Make load-dependent monotonic timer tests off-by-default
You can reenable them with @all, or say @fine_timing just to get
them.
2012-06-29 12:47:51 -04:00
Nick Mathewson
5671033752 Avoid (unlikely) overflow in bench_httpclient.c 2012-06-29 12:47:39 -04:00
Nick Mathewson
c8009d2985 Check return value of write() in regress.c 2012-06-29 12:47:03 -04:00
Nick Mathewson
59f21fd8fc Merge branch '21_nonrecursive' 2012-06-28 16:52:21 -04:00
Nick Mathewson
f2cea873bb Make all tests that hit the network disabled by default
To run only these tests, run test/regress with @live_net.  To run all
tests, run test/regress with @all.
2012-06-28 13:18:28 -04:00
Nick Mathewson
ef7c4f7956 Update to latest tinytest (911b4f0349377) 2012-06-28 12:58:46 -04:00
Nick Mathewson
def3b83419 Make test_evutil_monotonic a little more tolerant 2012-06-28 12:57:58 -04:00
Nick Mathewson
9cd5acb511 Make th_base_lock nonrecursive
This is necessary for making some thread libraries work with
event.c, and might get better performance with others.

The biggest change required here was that we needed to make some
internal code that had previously called event_add and event_del
call the nolock variants.
2012-06-28 12:01:38 -04:00
Nick Mathewson
108896abcc Merge branch 'master' of ssh://github.com/libevent/libevent 2012-06-28 11:42:25 -04:00
Nick Mathewson
e2d7d98d9d remove a now-unused var in thread_deferred_cb_skew test 2012-06-28 11:37:45 -04:00
Nick Mathewson
8a739b3492 Merge branch '21_event_callback_v3' 2012-06-28 11:36:52 -04:00
Nick Mathewson
ea92fba36c Avoid a resource leak on error in http client benchmark 2012-06-25 13:55:45 -04:00
Nick Mathewson
0de587f47e Simplify and correct evutil_open_closeonexec_
The original code needlessly called open in its two- or three-
argument format depending on the O_CREAT flag; this should not be
needed.

The code also leaked an fd if fcntl() failed.

Reported by Dave Hart.
2012-06-25 12:19:26 -04:00
Dave Hart
1aaf9f013b Avoid giving a spurious warning when timerfd support is unavailable
We forgot to do the obligatory "Check if there is no syscall there"
dance when calling timerfd_create().

(Commit message by Nick)
2012-06-18 10:31:38 -04:00
Simon Liu
be7a95c629 Make event_pending() threadsafe.
(Commit message by Nick)
2012-06-14 13:38:33 -04:00
Nick Mathewson
117e3273dc Add GCC annotations so that the vsprintf functions get checked properly 2012-06-14 13:25:10 -04:00
Nick Mathewson
e7bf4c84af Make the Makefile.nmake warning slightly less dire 2012-06-08 16:50:25 -04:00
Nick Mathewson
0ba0683bcf Add evutil_time.obj to Makefile.nmake 2012-06-08 16:45:01 -04:00