mirror of
https://github.com/libevent/libevent.git
synced 2025-01-31 09:12:55 +08:00
cf249e7d99
I'm running a fairly simple bit of test code using libevent2 with epoll and openssl bufferevents and I've run into a 100% cpu usage problem. Looking into it 100% usage was caused by epoll_wait constantly returning write events on the openssl socket when it shouldn't really have been looking for write events at all (N_ACTIVE_CALLBACKS() was returning 0 also). Looking a bit deeper eventbuffer_openssl socket seems to be requesting that the EV_WRITE event be removed when it should, but the event isn't actually being removed from epoll. Continuing to follow this I think I've found a bug in event_changelist_del. For evpoll event_del calls event_changelist_del which caches the change which is then actioned later when evpoll_dispatch is called. In event_changlist_del there is a check so that if the currently changed action is an add then the cached action is changed to a no-op rather than a delete (which makes sense). The problem arises if there are more than two add or delete operations between calls to dispatch, in this case it's possible that the delete is turned into a no-op when it shouldn't have been. For example starting with the event on, a delete followed by an add and then another delete results in a no-op when it should have been a delete (I added a fair bit of debug output that seems to confirm this behaviour). I've applied a small change that checks the original old_event stored with the change and only converts the delete to a no-op if the event isn't on in old_event. This seems to have fixed my problem.
56 lines
1.6 KiB
Makefile
56 lines
1.6 KiB
Makefile
|
|
CFLAGS=/I.. /I../include /I../WIN32-Code /I../compat /DWIN32 /DHAVE_CONFIG_H
|
|
|
|
CFLAGS=$(CFLAGS) /Ox /W3 /wd4996 /nologo
|
|
|
|
REGRESS_OBJS=regress.obj regress_buffer.obj regress_http.obj regress_dns.obj \
|
|
regress_testutils.obj \
|
|
regress_rpc.obj regress.gen.obj \
|
|
regress_et.obj regress_bufferevent.obj \
|
|
regress_listener.obj regress_util.obj tinytest.obj \
|
|
regress_main.obj regress_minheap.obj regress_iocp.obj
|
|
|
|
OTHER_OBJS=test-init.obj test-eof.obj test-weof.obj test-time.obj \
|
|
bench.obj bench_cascade.obj bench_http.obj bench_httpclient.obj \
|
|
test-changelist.obj
|
|
|
|
PROGRAMS=regress.exe \
|
|
test-init.exe test-eof.exe test-weof.exe test-time.exe \
|
|
test-changelist.exe
|
|
|
|
# Disabled for now:
|
|
# bench.exe bench_cascade.exe bench_http.exe bench_httpclient.exe
|
|
|
|
|
|
LIBS=..\libevent.lib ws2_32.lib shell32.lib advapi32.lib
|
|
|
|
all: $(PROGRAMS)
|
|
|
|
regress.exe: $(REGRESS_OBJS)
|
|
$(CC) $(CFLAGS) $(LIBS) $(REGRESS_OBJS)
|
|
|
|
test-init.exe: test-init.obj
|
|
$(CC) $(CFLAGS) $(LIBS) test-init.obj
|
|
test-eof.exe: test-eof.obj
|
|
$(CC) $(CFLAGS) $(LIBS) test-eof.obj
|
|
test-changelist.exe: test-changelist.obj
|
|
$(CC) $(CFLAGS) $(LIBS) test-changelist.obj
|
|
test-weof.exe: test-weof.obj
|
|
$(CC) $(CFLAGS) $(LIBS) test-weof.obj
|
|
test-time.exe: test-time.obj
|
|
$(CC) $(CFLAGS) $(LIBS) test-time.obj
|
|
|
|
bench.exe: bench.obj
|
|
$(CC) $(CFLAGS) $(LIBS) bench.obj
|
|
bench_cascade.exe: bench_cascade.obj
|
|
$(CC) $(CFLAGS) $(LIBS) bench_cascade.obj
|
|
bench_http.exe: bench_http.obj
|
|
$(CC) $(CFLAGS) $(LIBS) bench_http.obj
|
|
bench_httpclient.exe: bench_httpclient.obj
|
|
$(CC) $(CFLAGS) $(LIBS) bench_httpclient.obj
|
|
|
|
clean:
|
|
-del $(REGRESS_OBJS)
|
|
-del $(OTHER_OBJS)
|
|
-del regress.exe
|