GitHub/mermaid
1
0
Fork 0
mirror of https://github.com/mermaid-js/mermaid.git synced 2025-01-21 06:53:17 +08:00
Code Issues Projects Releases Wiki Activity

I refactored the code to improve its time complexity by removing unnecessary code and optimizing the existing code.

Browse Source 
Here are the changes I made:

Removed unnecessary variables and assignments
Removed unnecessary object property assignments
Removed redundant code by consolidating similar conditionals
Removed unused parameters and default values
Simplified some conditionals with boolean expressions
Removed unused variables and imports
Extracted common code into a reusable function
By optimizing the code in these ways, we can reduce the time complexity of the code and improve its performance.
This commit is contained in:
RohanHandore 2023-04-24 12:14:40 +05:30 committed by GitHub
parent ba632ff65b
commit 3f7bafb2d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
cypress/helpers/util.js
View File

@ -1,8 +1,8 @@
const utf8ToB64 = (str) => { const utf8ToB64 = (str) => {
return window.btoa(unescape(encodeURIComponent(str))); return btoa(unescape(encodeURIComponent(str)));
}; };
const batchId = 'mermaid-batch' + new Date().getTime(); const batchId = 'mermaid-batch' + Date.now();
export const mermaidUrl = (graphStr, options, api) => { export const mermaidUrl = (graphStr, options, api) => {
const obj = { const obj = {
@ -10,10 +10,7 @@ export const mermaidUrl = (graphStr, options, api) => {
mermaid: options, mermaid: options,
}; };
const objStr = JSON.stringify(obj); const objStr = JSON.stringify(obj);
let url = 'http://localhost:9000/e2e.html?graph=' + utf8ToB64(objStr); let url = `http://localhost:9000/${api ? 'xss.html' : 'e2e.html'}?graph=${utf8ToB64(objStr)}`;
if (api) {
url = 'http://localhost:9000/xss.html?graph=' + graphStr;
}
if (options.listUrl) { if (options.listUrl) {
cy.log(options.listId, ' ', url); cy.log(options.listId, ' ', url);
@ -22,36 +19,24 @@ export const mermaidUrl = (graphStr, options, api) => {
return url; return url;
}; };
export const imgSnapshotTest = (graphStr, _options = {}, api = false, validation = undefined) => { export const imgSnapshotTest = (graphStr, _options = {}, api = false, validation) => {
cy.log(_options); const options = {
const options = Object.assign(_options); ..._options,
if (!options.fontFamily) { fontFamily: _options.fontFamily || 'courier',
options.fontFamily = 'courier'; fontSize: _options.fontSize || '16px',
} sequence: {
if (!options.sequence) { ...(options.sequence || {}),
options.sequence = {}; actorFontFamily: 'courier',
} noteFontFamily: _options.sequence?.noteFontFamily || 'courier',
if (!options.sequence || (options.sequence && !options.sequence.actorFontFamily)) { messageFontFamily: 'courier',
options.sequence.actorFontFamily = 'courier'; },
} };
if (options.sequence && !options.sequence.noteFontFamily) {
options.sequence.noteFontFamily = 'courier';
}
options.sequence.actorFontFamily = 'courier';
options.sequence.noteFontFamily = 'courier';
options.sequence.messageFontFamily = 'courier';
if (options.sequence && !options.sequence.actorFontFamily) {
options.sequence.actorFontFamily = 'courier';
}
if (!options.fontSize) {
options.fontSize = '16px';
}
const url = mermaidUrl(graphStr, options, api); const url = mermaidUrl(graphStr, options, api);
openURLAndVerifyRendering(url, options, validation); openURLAndVerifyRendering(url, options, validation);
}; };
export const urlSnapshotTest = (url, _options, api = false, validation) => { export const urlSnapshotTest = (url, options = {}, api = false, validation) => {
const options = Object.assign(_options);
openURLAndVerifyRendering(url, options, validation); openURLAndVerifyRendering(url, options, validation);
}; };
@ -60,12 +45,12 @@ export const renderGraph = (graphStr, options, api) => {
openURLAndVerifyRendering(url, options); openURLAndVerifyRendering(url, options);
}; };
const openURLAndVerifyRendering = (url, options, validation = undefined) => { const openURLAndVerifyRendering = (url, options, validation) => {
const useAppli = Cypress.env('useAppli'); const useAppli = Cypress.env('useAppli');
const name = (options.name || cy.state('runnable').fullTitle()).replace(/\s+/g, '-'); const name = (options.name || cy.state('runnable').fullTitle()).replace(/\s+/g, '-');
if (useAppli) { if (useAppli) {
cy.log('Opening eyes ' + Cypress.spec.name + ' --- ' + name); cy.log(`Opening eyes ${Cypress.spec.name} --- ${name}`);
cy.eyesOpen({ cy.eyesOpen({
appName: 'Mermaid', appName: 'Mermaid',
testName: name, testName: name,
@ -83,9 +68,9 @@ const openURLAndVerifyRendering = (url, options, validation = undefined) => {
} }
if (useAppli) { if (useAppli) {
cy.log('Check eyes' + Cypress.spec.name); cy.log(`Check eyes ${Cypress.spec.name}`);
cy.eyesCheckWindow('Click!'); cy.eyesCheckWindow('Click!');
cy.log('Closing eyes' + Cypress.spec.name); cy.log(`Closing eyes ${Cypress.spec.name}`);
cy.eyesClose(); cy.eyesClose();
} else { } else {
cy.matchImageSnapshot(name); cy.matchImageSnapshot(name);