GitHub/nodemcu-firmware
1
0
Fork 0
mirror of https://github.com/nodemcu/nodemcu-firmware.git synced 2025-01-30 21:12:55 +08:00
Code Issues Projects Releases Wiki Activity

Fix IGMP timer (#3476)

Browse Source 
LWIP_RAND() return type is int, value returned is sometimes negative.
This causes timer to sometimes (often) go outside of max_time, which in turn causes IGMP snoopers or IGMP routers to drop the subscription
This commit is contained in:
Johan Ström 2021-11-19 22:47:54 +01:00 committed by GitHub
parent 77e5359087
commit f7b48b9214
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/lwip/core/ipv4/igmp.c
View File

@ -731,7 +731,7 @@ igmp_start_timer(struct igmp_group *group, u8_t max_time)
if(max_time == 1)
group->timer = 1;
else
group->timer = (LWIP_RAND() % (max_time - 1)) + 1;
group->timer = (u16_t) ((unsigned int)LWIP_RAND() % (max_time - 1)) + 1;
}
/**